Bug in MemIoOps

Question

jawhiting opened this issue 5 years ago · 3 comments

In z80core/memIoOps, your setPorts method sets the ram member variable instead of the ports.
(sorry, I meant MemIoOps. Line 43).

Answer 1 · 2021-04-25T16:39:59.000Z

I cant't understand what's the problem. Anyway, the MemIoOps default implementacion isn't used in JSpeccy.

Answer 2 · 2021-04-25T17:05:52.000Z

Sorry I mean line 43 should be:
z80ports = ports;

I don’t know anything about the codebase, was just browsing and noticed it.

Answer 3 · 2021-04-25T17:11:15.000Z

Yes, it's true, thanks by your bug report.

I've corrected another two off-by-one bugs in constructor with param.

Best regards