jschauma/jass

Using example GITHUB_URL value routes to a bad address

Closed this issue · 1 comments

In your docs you don't specify that Github will be searched automatically without setting any variables. When using your example GITHUB_URL=https://api.github.com/users//keys Github fails because you add /.keys to the url.

Using the GITHUB_URL=https://github.com/.keys doesn't work because it doesn't output JSON

Also be wary of adding a trailing / to https://api.github.com/users//keys

Good: https://api.github.com/users/toddtimes/keys
Fail: https://api.github.com/users/toddtimes/keys/

Fixed via 9445f48

Sorry I took forever to take a look here.