jschneier/django-storages

New behaviour of S3 storage `exists()` breaks current workflow

Closed this issue · 2 comments

In our application, we allow overwriting large files on S3 (so, having file_overwrite=True). We were relying on the existing behavior of myfile.storage.exists(myfile.name) to render urls or a null-character. With the new check introduced in #1422 this behaviour breaks. The file has been generated and uploaded, but our template will not render the link, as it thinks the file does not exist.

Are we doing the check for exists wrong? I am happy to fix my own code, but in case this is an unforeseen side effect of #1422 I would like to report it here.

Also, thanks for all your work on this library, it makes working with S3 very easy!

This will break things for anyone (like me) using django-health-check.

Let's centralize discussion on #1430. Thanks for opening and apologies. I've posted my reasoning there but am open to reverting.