jschr/bootstrap-modal

Broken overflow due to bad height

ashleymcdonald opened this issue · 1 comments

bootstrap-modalmanager.js line 73

old:

                    .toggleClass('page-overflow', $(window).height() < that.$element.height());

new:

                    .toggleClass('page-overflow', $(window).height() < modal.$element.height());

without that its getting the wrong height for the modal and breaking page scrolling (that is the body tag)

This doesn't seem quite right. The point of page-overflow is detect whether the modalmanager's container (body) extends past the viewport. There is a separate modal-overflow class that is applied when the modal itself extends past the viewport. Can you reproduce your issue in a jsFiddle?