jscottsmith/react-scroll-parallax

CSS transforms handled by react-scroll-parallax are getting reset.

rahuuzz opened this issue · 4 comments

rahuuzz commented

Actual Behavior (bug)

state update is causing parallax to reset to initial after reaching endScroll.
An example for demo code can be found here

Expected Behavior

Expecting to prevent resetting the transformations done by react-scroll-parallax after endScroll position.

Steps to Reproduce the Problem

  1. Use the above code sandbox link. (Or create some parallax components and trigger some state update (i did it in onProgressChange))
  2. Scroll till the parallax completes ( scroll position = 460)
  3. See that the transformations are reset (on reaching scroll position 461)

Environment

  • Framework: next-js
  • Node Version: 14
  • Platform: macOS
  • Browser: Google Chrome 98.0.4758.109
jscottsmith commented

Thanks for the easy reproduction -- I'll work on a fix this week.

jscottsmith commented

Fix published in v3.0.4. Let me know if there's any other issue.

rahuuzz commented

Tried updating to 3.0.4 still havent solved the issue. preview

jscottsmith commented

ahh, remove the lockfile, the issue was in the dependency and it's probably still using the old version. https://codesandbox.io/s/vigilant-hofstadter-rhthqo?file=/package.json

  • 👍1
  • ❤️1