jsdf/react-native-htmlview

Typing for HTMLViewNode on Typescript

lethanhan97 opened this issue · 2 comments

lethanhan97 commented

Hey guys, stumbled upon this issue.

When I'm trying to provide the renderNode prop to RNHTMLView using Typescript, an argument node with type HTMLViewNode was provided

The HTMLViewNode type indicate that node doesn't have a type name children. However, it turns out that node does have the children type

Could the type be updated so that children is declared in HTMLViewNode?

const renderNode = (node: HTMLViewNode) => {
    const nodeChildren = node.children // IDE will show error

    // more code
}

Type declaration on react-native-htmlview/index.d.ts

Screenshot 2022-01-20 at 10 59 39 AM

Package info:

  • react-native-htmlview: 0.16.0
  • @types/react-native-html-view: 0.12.2
danpettay commented

I am also having this issue and agree that the HTMLViewNode type should be updated to include children. @lethanhan97 it looks like this repo hasn't been updated in quite some time. were you able to find a workaround?