decimal precision in QUANTYPE

Question

Davidcc opened this issue 3 years ago · 6 comments

Hello, we are trying to send quantities such as 0.16667 as the quantity on a CreditMemoLineAdd, and the QBXML being generated is 0.17.

I believe this is due to the use of
return _value.ToString("F", CultureInfo.InvariantCulture);

in the FLOATTYPE superclass. Since (I believe) QBXML supports 5 decimal places, would "F5" be more appropriate here?

Answer 1 · 2021-09-24T22:38:54.000Z

Sounds right. You could send a PR with unit tests, I'll be happy to merge.
FYI, AmtType can only have 2 decimals

Answer 2 · 2021-09-25T22:10:44.000Z

I have finished the changes but I think I need someone with more permissions to create a branch?

Answer 3 · 2021-09-25T22:15:37.000Z

You should create a fork, commit to your fork, then in github it will ask you to do a pull request.

Answer 4 · 2021-09-30T17:17:42.000Z

Thanks for your help!

Answer 5 · 2021-09-30T17:26:47.000Z

No problem, I'll publish this today

Answer 6 · 2021-09-30T18:39:53.000Z

This is released as 3.0.2
I have released the WebConnector as well with the new version since we changed a public API (private->protected)