jsgoupil/quickbooks-sync

Support customizable iterator records

mscappini opened this issue · 2 comments

Currently, the StepQueryWithIterator<T, Y>.ExecuteRequest method simply sets the QbIteratorRequest.MaxReturned value to 100. We could check for an existing valid value and set one if there isn't.

int maxVal;
bool isValid = int.TryParse(request.MaxReturned, out maxVal);

// Max 200 is arbitrary--maybe there shouldn't be a max.
if (!isValid || (isValid && (0 > maxVal || maxVal > 200)))
{
    // Not a valid max returned value. Set to 100 by default.
    request.MaxReturned = "100";
}

👍

Implemented 1674918.