jsmrcaga/action-netlify-deploy

Option to skip nvm

penx opened this issue · 4 comments

penx commented

Thanks for building this action!

At the point I run action-netlify-deploy, my application has already been installed and built, and I have the version of node that I need.

I do have an .nvmrc file though, so this step I think will still install nvm, even though I don't need it.

fb6a5f9

Would it be possible to have an option to skip nvm rather than detecting it? 🙏

jsmrcaga commented

Hi there @penx !

I had some time this evening and opened a simple pull request here
#33
if it's okay with you, can I let you review/approve. I'll then release a new version and hopefully you'll be good!

  • 👍1
penx commented

Looks great, thanks!

jsmrcaga commented

@penx I've released version 1.8.0, if it works for you (using use_nvm: false) I'll let you close this issue! Thanks!

penx commented

great, thanks, may not get a chance to test this until September but I've looked at the code and pretty certain it will work, thanks!

  • 👍1