Remove example files no longer in use
Anthropic opened this issue · 11 comments
There was a PR #221 that has left four schema in the root (address, calendar, card, geo) that appear to serve no purpose as they now link to empty object schemas. I think we need to decide to either remove them completely or alter the links to their new location within the learn folder.
My first attempt to update the symlinks #225 failed CI so i closed it, so not sure what went wrong but seems updating symlinks has more to it anyway.
Am I correct in assuming that we all tend to lean toward delete?
I left them in because removing them broke the build and I couldn't really ascertain why at the time. The improvements in the learning documentation seemed to outweigh empty schema.
There are zero references anywhere in the repo to the files now empty...
/example/address.json
/example/calendar.json
/example/card.json
/example/geo.json
/example/index.md
/example/person.json
...so not quite sure what's happening.
I've created a pull request which removes them -- it has failed so perhaps we will have data that tells us exactly why within the CI system.
jekyll 3.7.3 | Error: No such file or directory @ realpath_rec - /home/travis/build/json-schema-org/json-schema-org.github.io/example
There is another error further up the log but I don't think it's related.
@retrosight the schemas are referenced in the symlink files in root
address, card, calendar and geo
I suspect somewhere in the jekyll script it is checking them.
Well, what appears in the clone of the repository...
{}
...and what appears in the GitHub UI...
example/address.json
...are very different.
Trying git rm {file} now.
@retrosight it is a linux symlink, the file is a pointer and the current pointer is to example/address.json and the content of that file is {}
Yup. It's fixed.
@philsturgeon @handrews @Relequestual Should be an easy merge.
@retrosight @Anthropic thanks!