json schema validation is fails on empty graph

Question

json schema validation is fails on empty graph

schaumb opened this issue 5 years ago · 3 comments

schaumb commented 5 years ago

Json schema fails on empty graph.

The python testcase is missing. The https://www.jsonschemavalidator.net/ and the python validator are shows the error.

Answer 1 · 2021-03-23T13:49:10.000Z

Not sure I'm following - it should fail on an empty graph object as there are required properties in the graph object.

Are you saying it should not fail? or that we have a test that is passing that should fail?

Answer 2 · 2021-03-23T14:03:00.000Z

Schema:
https://github.com/jsongraph/json-graph-specification/blob/ce5ed4007c61df23dd0835094a7b69364ab445d9/json-graph-schema_v2.json

Graph:

Examples

Additional examples
empty single graph

{
  "graph": {}
}

The documentation says this is the empty graph representation.
The schema is failing on this graph, because oneOf matches on multiple subschema (see: img).

This empty graph is not tested in the test directory.

Answer 3 · 2021-03-23T14:14:29.000Z

Ah - thanks - I’ll need to update the documentation.

…

On Mar 23, 2021, at 10:03 AM, Bela Schaum ***@***.***> wrote: Schema: https://github.com/jsongraph/json-graph-specification/blob/ce5ed4007c61df23dd0835094a7b69364ab445d9/json-graph-schema_v2.json <https://github.com/jsongraph/json-graph-specification/blob/ce5ed4007c61df23dd0835094a7b69364ab445d9/json-graph-schema_v2.json> Graph: Examples Additional examples empty single graph { "graph": {} } The documentation says this is the empty graph representation. The schema is failing on this graph, because oneOf matches on multiple subschema (see: img). This empty graph is not tested in the test directory. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#53 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AACZF53ZNRPMVPR7I4BPP7TTFCNSNANCNFSM4ZT565JA>.