Add a photo to the bio section
michaeldk opened this issue · 20 comments
As much as it said that physical appearances shouldn't influence a resume, I believe the choice should be left to the user whether or not he wants to use a photo in his resume.
Agreed. Some templates might choose to use gravatar for photos, though the specification could contain an alternative field
+1
Optional photo would be a good addition.
+1 for optional.
+1 for optional.
Need need some suggestions for the field name.
- picture
- profilePicture
- pictureUrl
- avatar
- mugshot
- selfie
+1 profilePicture
-1 for avatar, mugshot, and selfie
Rationale: If I use a picture of myself, it is not an avatar. Mugshot and selfie reduce the level of professionalism, and are not as easily understood by multiple language backgrounds/cultures.
In #80 "pictureUrl" is used, but I think that's superfluous. As far as I know, there's not other way to provide a picture in a JSON document, than specifying an URL to a picture (aside maybe from a base64 encoded data-url?). So the best options in my opinion are "profilePicture" or just "picture".
I assume your last two suggestions are more in jest @thomasdavis ;) And "avatar" signifies a small picture to be used on a forum or other online community, not a real photo.
I'm sad to see no consensus on selfie =(
My vote goes to picture, I like to think the spec can get away with being
casual in that sense.
On Thu, Jul 10, 2014 at 5:25 PM, Daan Debie notifications@github.com
wrote:
In #80 #80 "pictureUrl"
is used, but I think that's superfluous. As far as I know, there's not
other way to provide a picture in a JSON document, than specifying an URL
to a picture (aside maybe from a base64 encoded data-url?). So the best
options in my opinion are "profilePicture" or just "picture".
I assume your last two suggestions are more in just @thomasdavis
https://github.com/thomasdavis ;) And "avatar" signifies a small
picture to be used on a forum or other online community, not a real photo.—
Reply to this email directly or view it on GitHub
#29 (comment)
.
Thomas Davis
http://thomasdav.is
VP of Tech - Earbits - http://earbits.com
Co-founder - Cdnjs - http://cdnjs.com
Founder - Backbone Tutorials - http://backbonetutorials.com
Experimenting with a new label called "Decision Needed", this issue has it applied. It means we will be passing something through in the very near future.
picture is definitely the best name. Updated the pull request as well.
Optional, of course. But we don't have marked optional and required fields yet, anyway, right?
The only case where picture is not specific enough (and profilePicture might be) is if there is more than one picture on a resume. (I cannot think of such an instance, can you?)
Note: Specs in general are not casual; content based on specs has more flexibility in that regard.
I cannot think of more picture occurrences in resumes.
Can't think of such an instance, either. Many people will not even have a single picture, and I've never seen a resume with two pictures. That should be fine.
Okay, I think picture will suffice for now. Last comments end in 30mins then I will mark this as ready.
The picture field will be added to the bio field as type string
string is a primitive type of JSON schema, I'm still learning more about JSON schema as time goes on so we will adhere to just using string until I know all the repercussions of using type url
I do think we should choose between string and url before v1 is released :) I'd love to make a PR for this one, but I promised my wife we'd leave for the beach in 5 minutes. So I'm off until further notice ;)
Sure, we will do another PR at a later date that corrects all the types.
Shouldn't be too much of a problem.
On Sat, Jul 12, 2014 at 7:57 PM, Daan Debie notifications@github.com
wrote:
I do think we should choose between string and url before v1 is released
:) I'd love to make a PR for this one, but I promised my wife we'd leave
for the beach in 5 minutes. So I'm off until further notice ;)—
Reply to this email directly or view it on GitHub
#29 (comment)
.
Thomas Davis
http://thomasdav.is
VP of Tech - Earbits - http://earbits.com
Co-founder - Cdnjs - http://cdnjs.com
Founder - Backbone Tutorials - http://backbonetutorials.com
I think we can close this as #80 fixes this.