Bug: Template strings not being extracted when using self-closing tags
aleesaan opened this issue · 6 comments
Is there an existing issue for this?
- I have searched the existing issues
Is this a regression?
No
Current behavior
Angular 15.1.0 has introduced self-closing tags for custom elements, but when trying to extract keys from a template using self-closing tags, no keys get extracted.
Expected behavior
Keys should be extracted also in files using self-closing tags.
Please provide a link to a minimal reproduction of the bug
Transloco Config
No response
Debug Logs
No response
Please provide the environment you discovered this bug in
Transloco: 4.2.6
Transloco Keys Manager: 3.7.0
Angular: 15.1.x
Node: 16
Package Manager: 8
OS:Additional context
Simply updating the @angular/compiler to >=15.1 should do the trick, as it will correctly parse the nodes for files with self-closing custom tags.
I would like to make a pull request for this bug
Yes
@aleesaan This is a big issue since this also requires moving this package to ESM instead of commonjs.
Would you like to take a shot at this task? I started but didn't find the time to finish the task.
The next two weeks will be tight for me as well, I'm not sure I can pick this up sorry :(
@aleesaan It's ok, it will wait until someone will have the time to contribute 🙂
Any news on this? Maybe we can share the work...
We are also facing this issue.
@Ben305 I don't have the time to get to it, I tried starting but it's quite a lot of work.
Anyone who is willing is welcome to open a PR 🙂