Bug: Find without findings throws
lkuendig opened this issue · 2 comments
Is there an existing issue for this?
- I have searched the existing issues
Is this a regression?
Yes
Current behavior
We have no findings (no missing keys, no extra keys). When I run transloco-keys-manager find --translations-path assets/i18n/merged
I get the exception:
C:\workarea\services***\ui\node_modules@ngneat\transloco-keys-manager\keys-detective\map-diff-to-keys.js:14
return keys.join('\n');
^
TypeError: keys.join is not a function
at mapDiffToKeys (C:\workarea\services*\ui\node_modules@ngneat\transloco-keys-manager\keys-detective\map-diff-to-keys.js:14:17)
at buildTable (C:\workarea\services*\ui\node_modules@ngneat\transloco-keys-manager\keys-detective\build-table.js:40:63)
at compareKeysToFiles (C:\workarea\services*\ui\node_modules@ngneat\transloco-keys-manager\keys-detective\compare-keys-to-files.js:94:34)
at findMissingKeys (C:\workarea\services*\ui\node_modules@ngneat\transloco-keys-manager\keys-detective\index.js:26:52)
at Object. (C:\workarea\services***\ui\node_modules@ngneat\transloco-keys-manager\index.js:38:42)
at Module._compile (node:internal/modules/cjs/loader:1101:14)
at Object.Module._extensions..js (node:internal/modules/cjs/loader:1153:10)
at Module.load (node:internal/modules/cjs/loader:981:32)
at Function.Module._load (node:internal/modules/cjs/loader:822:12)
at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:81:12)
Expected behavior
Find does not throw when all keys are fine
Please provide a link to a minimal reproduction of the bug
None
Transloco Config
No response
Debug Logs
No response
Please provide the environment you discovered this bug in
Transloco:
Transloco Keys Manager:
Angular:
Node:
Package Manager:
OS:
Additional context
No response
I would like to make a pull request for this bug
No
@lkuendig You are welcome to open a PR
@shaharkazaz I accidentally deleted the PR (first PR on github :)). can you add those 2 changes https://github.com/ngneat/transloco-keys-manager/pull/162/files. It's only a small bug/fix in case one has "key": {}
somewhere in the translations