Bug: Marker extraction is not working
Closed this issue ยท 3 comments
xemlock commented
Is there an existing issue for this?
- I have searched the existing issues
Is this a regression?
Yes
Current behavior
Strings annotated with marker
function aren't extracted. Looks like the code responsible is not aware that the package namespace has changed from @ngneat
to @jsverse
.
- https://github.com/jsverse/transloco-keys-manager/blob/master/src/keys-builder/typescript/marker.extractor.ts#L11
- https://github.com/jsverse/transloco-keys-manager/blob/master/src/keys-builder/typescript/index.ts#L35
Expected behavior
Marker extraction should work.
Please provide a link to a minimal reproduction of the bug
Any attempt to extract marker-annotated strings.
Transloco Config
No response
Debug Logs
No response
Please provide the environment you discovered this bug in
Transloco: 6.0.4
Transloco Keys Manager: 3.8.0
Angular: 17.1.0
Node: 18.18.0
Package Manager: 9.8.1
OS: macOS
Additional context
No response
I would like to make a pull request for this bug
Yes ๐
kekel87 commented
I also created a PR about it yesterday. It's not just marker that's no longer working.
shaharkazaz commented
This should be resolved in v4.0.1, can you please verify ๐
shaharkazaz commented
Feel free to reopen if not foxed ๐