`label-has-associated-control` - misleading error message
BillyLevin opened this issue · 1 comments
BillyLevin commented
This rule checks two things:
- A label has an associated control component
- The label contains accessible text
However, the error message never accounts for the second case. So, if we had this code:
function Thing() {
return (
<div>
<label htmlFor="js_id" />
<input id="js_id" />
</div>
);
}
We get the error message: A form label must be associated with a control.
, which is not actually what the issue is.
I think it would be helpful to have a separate error message for this case, something like: A form label must have accessible text.
to clear up any confusion between the two cases
BillyLevin commented
Somehow created a duplicate of #1005