Passing objects by referrence instead by value.
Closed this issue · 1 comments
silviucpp commented
Hello,
I see all over the places that objects are passed by value instead by reference:
INIReader(std::string filename);
You probably know that it is a bad idea to pass objects by value due to its performance impact.
Correct is:
INIReader(const std::string& filename);
jtilly commented
Fair point. This has been fixed upstream a while ago. It's probably time to pull these changes in here, too.