sidebar scroll orientation issue
Closed this issue · 4 comments
I noticed when testing on my iphone, both my personal project & the demo project for this repo have the following issue (that the original snap.js doesnt seem to)
Whenever you change the orientation on a mobile phone, for example from portrait to landscape, the sidebar scrollable area no longer works. (although if you hard refresh the page it does)
Couldnt find any other mentions of this issue, sorry If I am missing something
Interesting - I haven't experienced this myself. I just tried reproducing at hamfz.github.io in Chrome on my droid razr hd and in Safari on my iPhone 5 with no luck. I don't have other physical mobile devices on hand but if you have a different one I can try an emulator.
Also, I noticed you aren't using angular-snap-only.css alongside snap.css (regular angular-snap.css bundles the Snap.js styles) which is - just wanted to make sure you knew it was there. The extra styles mostly just make sure there is no flash of sidebar content before the directive gets a change to run.
Thanks for the tip -- I will make sure to include the correct stylesheets.
Edit: Even after including the seperate css files, I still seem to be getting the sidebar flash while the directive is loading. Unsure what I am loading incorrectly
Regarding the initial issue, I forgot that I was not using safari but Chrome for iOS (aug 13 release).
I should have been more thoughtful to include that in the original description. I also retested in safari and had working as expected results. (I am on an iPhone 5 as well)
Sorry for going quiet, unfortunately I haven't had any luck reproducing this issue after hitting up a handful of folks to try on their phones. Are you still experiencing the same behavior? I believe there was a recent Chrome update, any change?
Feel free to reopen if you're still experiencing this issue or you're able to reproduce it.