jtsage/jquery-mobile-spinbox

feature request: step

daroczig opened this issue · 5 comments

First of all, thank you very much for this nice plugin.

I have some numeric fields that holds decimal numbers, so the current implementation (for integers) is not working for those fields. Is there any chance to add a "step" attribute to the spinbox so that the plus/minus buttons would increment/decrease the value by e.g. 0.1? I would be more than happy to see this feature.

I needed this option myself and have been able to add this functionality, would it be acceptable for me to push this?

@Cindres I would love to see your solution -- even in a forked repo. And I am pretty sure that @jtsage would also be likely to welcome a pull request.

If you head to my fork:
https://github.com/Cindres/jquery-mobile-spinbox

You'll now see the version with a "step" added. (so simply add step="val" to your input tag). You'll have to forgive me I'm quite new to GitHub so I haven't made a pull request before.

Cool, will check it soon! About the pull request, head to https://github.com/Cindres/jquery-mobile-spinbox/compare/jtsage:master...master and click on "Click to create a pull request for this comparison". There you will be able to add some details so that the owner of the repo would know what to merge there if he agrees.

Closed by #6