juancarlospaco/webgui

Linking on Windows fails: undefined reference to ShellExecute

ZoomRmc opened this issue · 1 comments

ZoomRmc commented

Linking on Windows fails with undefined reference to ShellExecute errors.

Possible source:

webgui/src/webview.h

Line 1502 in 820cedc

ShellExecute(0, 0, uri, 0, 0 , SW_SHOW );
Should it be ShellExecuteW?
Secondly, -lcomdlg32 isn't passed to the linker, otherwise a bunch of errors pop up for tinyfiledialogs.

juancarlospaco commented

@ZoomRmc Can you send PR with the mentioned changes?, I will merge.
I dont have Windows myself right now.