juftin/camply

Specific campgrounds not returned using GoingToCamp provider on windows

goleary opened this issue · 3 comments

goleary commented

Describe the bug

when I use

camply campgrounds --provider goingtocamp --rec-area 3

lots of campgrounds are listed

...
[2023-06-05 07:50:53] INFO     ⛰  Washington State Parks, Washington (#3) - 🏕  Twenty-Five Mile Creek State Park

                               (#-2147483548)
[2023-06-05 07:50:53] INFO     ⛰  Washington State Parks, Washington (#3) - 🏕  Twin Harbors State Park  (#-2147483547)

[2023-06-05 07:50:53] INFO     ⛰  Washington State Parks, Washington (#3) - 🏕  Wallace Falls State Park  (#-2147483545)

[2023-06-05 07:50:53] INFO     ⛰  Washington State Parks, Washington (#3) - 🏕  Wanapum State Park  (#-2147483544)

[2023-06-05 07:50:53] INFO     ⛰  Washington State Parks, Washington (#3) - 🏕  Wenatchee Confluence State Park

                               (#-2147483543)
[2023-06-05 07:50:53] INFO     ⛰  Washington State Parks, Washington (#3) - 🏕  Yakima Sportsman State Park

                               (#-2147483540)

When i try to search a specific one of these campgrounds I get this message:

camply campgrounds --provider goingtocamp --rec-area 3 --campground -2147483572
[2023-06-05 07:53:33] INFO     Using Camply Provider: "GoingToCamp"
[2023-06-05 07:53:33] INFO     Retrieving Facility Information for Recreation Area ID: `3`.
[2023-06-05 07:53:33] INFO     0 Matching Campgrounds Found
[2023-06-05 07:53:33] CAMPLY   Exiting camply 👋

Original Camply Command (with --debug)

camply campgrounds --provider goingtocamp --rec-area 3 --campground -2147483572

Expected behavior
I expect information about the campground to be returned

Console Output (with --debug)

[2023-06-05 08:00:13] CAMPLY   camply, the campsite finder ⛺️

[2023-06-05 08:00:13] INFO     Using Camply Provider: "GoingToCamp"
[2023-06-05 08:00:13] DEBUG    Setting up camply debugging
[2023-06-05 08:00:13] DEBUG    Camply Version: 0.23.0
[2023-06-05 08:00:13] DEBUG    Python Version: 3.10.5
[2023-06-05 08:00:13] DEBUG    Platform: win32
[2023-06-05 08:00:13] INFO     Retrieving Facility Information for Recreation Area ID: `3`.
[2023-06-05 08:00:13] DEBUG    Starting new HTTPS connection (1): washington.goingtocamp.com:443
[2023-06-05 08:00:14] DEBUG    https://washington.goingtocamp.com:443 "GET /api/resourceLocation HTTP/1.1" 200 None
[2023-06-05 08:00:14] DEBUG    Starting new HTTPS connection (1): washington.goingtocamp.com:443
[2023-06-05 08:00:14] DEBUG    https://washington.goingtocamp.com:443 "GET /api/maps HTTP/1.1" 200 None
[2023-06-05 08:00:14] INFO     0 Matching Campgrounds Found
[2023-06-05 08:00:14] CAMPLY   Exiting camply 👋

Additional context

When I use a similar command for recreation.gov, things work as expected:

camply campgrounds --campground 259084
[2023-06-05 08:03:31] CAMPLY   camply, the campsite finder ⛺️

[2023-06-05 08:03:31] INFO     Using Camply Provider: "RecreationDotGov"
[2023-06-05 08:03:33] INFO     1 Matching Campgrounds Found
[2023-06-05 08:03:33] INFO     ⛰  Olympic National Park, USA (#2881) - 🏕  Fairholme Campground  (#259084)

[2023-06-05 08:03:33] CAMPLY   Exiting camply 👋
juftin commented

Huh, that's weird. I suspect maybe this has something to do with the negative ID. Let me take a look in the coming days hopefully (big camping trip coming up), @acaloiaro may also know

juftin commented

Figured it out 👍 Should release momentarily

goleary commented

dope, thanks for the quick fix!