DJ rings are missing with hitboxes visualization On

Question

DJ rings are missing with hitboxes visualization On

Opened this issue 2 years ago · 5 comments

gnaomo commented 2 years ago

Used to be fixed with #37

Answer 1 · 2022-11-07T18:56:03.000Z

Somehow an old code refactor removed this (https://github.com/jugeeya/UltimateTrainingModpack/pull/83/files)

Added again here: ccac7c9

Answer 2 · 2022-11-08T22:46:38.000Z

i checked latest beta but it's still not fixed 😢

Answer 3 · 2022-11-09T00:42:12.000Z

well i found out that rings only appear if a dj and an aerial animation starts on the same frame

Answer 4 · 2022-11-25T14:13:31.000Z

@gnaomo I'm still familiarizing myself with the codebase, so take this with a grain of salt, but perhaps this might be the intended behavior of the game?

Reference: PSA: The double jump ripple doesn't show up if you input an aerial on the first frame after double jumping

--Reddit

Are we certain this behavior is caused by the training mod?

Answer 5 · 2022-11-26T00:02:34.000Z

What I was trying to say is that DJ rings still did not show up, always, with hitbox vis. on (I don't know now on latest beta) even after jugeeya's commit ccac7c9

That gif was a different thing, sorry if I've may confused things. It's an interesting side effect to the main bug of this issue thread, but I would not call that a TMP fault