jugeeya/UltimateTrainingModpack

PT CPU breaks when loadstate using Mash Triggers

Closed this issue · 2 comments

e.g. CPU is set to Mash trigger "Always" and Mash Toggle "Fsmash" (or pretty much every move that changes the fighter kind status), we then load state. CPU will respawn from angel plat.

ezgif-2-e9f6c1b07c

It seems that during the killing process (the very first steps of loading a save state) the code will not get through this statement as usual

if status == FIGHTER_STATUS_KIND_REBIRTH {

but instead the mash trigger will override status and the code will see that PT CPU is not 'REBIRTH', messing up everything.
Or at least this my interpretation of what is happening....

Normal situation

image

Bugged out, with Charizard first frame of F-Smash

Next frame will be CPU on angel plat

image

Probably we can just check here if save_state.state == NoAction.

https://github.com/jugeeya/UltimateTrainingModpack/blob/main/src/training/mash.rs#L146

Fixed in latest beta.