juggle/resize-observer

rollup.js warns about circular dependencies

austinw-fineart opened this issue · 2 comments

austinw-fineart commented

Describe the bug

The 'this' keyword is equivalent to 'undefined' at the top level of an ES module, and has been rewritten
Circular dependency: node_modules\@juggle\resize-observer\lib\ResizeObserverController.js -> node_modules\@juggle\resize-observer\lib\utils\scheduler.js -> node_modules\@juggle\resize-observer\lib\ResizeObserverController.js
Circular dependency: node_modules\@juggle\resize-observer\lib\ResizeObserverController.js -> node_modules\@juggle\resize-observer\lib\algorithms\hasActiveObservations.js -> node_modules\@juggle\resize-observer\lib\ResizeObserverController.js
Circular dependency: node_modules\@juggle\resize-observer\lib\ResizeObserverController.js -> node_modules\@juggle\resize-observer\lib\algorithms\hasSkippedObservations.js -> node_modules\@juggle\resize-observer\lib\ResizeObserverController.js
Circular dependency: node_modules\@juggle\resize-observer\lib\ResizeObserverController.js -> node_modules\@juggle\resize-observer\lib\algorithms\broadcastActiveObservations.js -> node_modules\@juggle\resize-observer\lib\ResizeObserverController.js
Circular dependency: node_modules\@juggle\resize-observer\lib\ResizeObserverController.js -> node_modules\@juggle\resize-observer\lib\algorithms\gatherActiveObservationsAtDepth.js -> node_modules\@juggle\resize-observer\lib\ResizeObserverController.js

To Reproduce
Simply import @juggle/resize-observer in a rollup.js project.

Frameworks/Libraries used

  • rollup: 1.29.0

Desktop (please complete the following information):

  • OS: windows
  • Browser: chrome
  • Version: 79
TremayneChrist commented

Hi @austinw-fineart this should have been fixed in v3. It sounds like you're probably using an older version.

austinw-fineart commented

Oh nice! And yeah, I was still on 2.5.0, sorry about that!

  • 👍1