juicycleff/casbin-mongodb-adapter

Why force users to install with yarn?

fchristl opened this issue · 8 comments

I am working on a project where I'd like to use this package. However, when trying to install with npm, the (intended) error message pops up: casbin-mongo-adapter must be installed with Yarn.

Is there any reason behind this rather than a a preference for Yarn? I work in an all-npm environment (including our CI servers, all other team members' development environments, ...), so changing to Yarn for just this one package is not an option.

If there is no other reason rather than a preference for Yarn, would you agree to removing the preinstall hook?

Update: I find this especially confusing as the README states to install using npm.

I think we can support NPM.

Here's a PR that addresses the issue plus two minor build problems: #3

Hi @hsluoyz , did you already have a chance to take a look at my PR? It'd be great if we could get a new version published that allows installing via NPM.

I cannot merge it. Is the owner @juicycleff here?

@fchristl @hsluoyz I'm making a release for this now

And sorry for the delay, I was quite busy

Just made a release now, closing this. Also included some minor adjustment to the mongo collection and database naming

Great, thank you so much