c++ issues

Question

c++ issues

Closed this issue 8 years ago · 4 comments

Let's talk about some details in your c++ code.

Answer 1 · 2017-01-17T11:40:34.000Z

from GaleDiagram.cpp:

vector<int> Gale_Diagram::findMissing(int i, int j, int k, int l) const{
    vector<int> pointNums(points.size());
    for(int a=0; a<points.size(); a++) pointNums[a]=a;

Here you could use a std::index_sequence and have clearer code

Answer 2 · 2017-01-17T11:46:45.000Z

That is indeed a clearer way to set it up. I hadn't heard of it before.

Answer 3 · 2017-01-17T11:58:51.000Z

I opened a new pull request where I'll add comments. In the meantime, could you please upload your Makefile or whatever infrastructure you have for actually compiling the project?

I have igraph and gmpxx installed.

Answer 4 · 2017-01-17T12:04:10.000Z

I ran the code in Xcode (mac c++ editor) and as such didn’t have any makefile. To run the code I added to “other linker flags” -lgmp -lgmpxx -ligraph Added to "library search path" /usr/local/lib/ And to "header search path” /usr/local/include/ /usr/local/include/igraph I hope this is sufficient.

…

Op 17 jan. 2017, om 12:58 heeft julian-upc ***@***.***> het volgende geschreven: I opened a new pull request where I'll add comments. In the meantime, could you please upload your Makefile or whatever infrastructure you have for actually compiling the project? I have igraph and gmpxx installed. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#141 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AKuVlTazwAWG3nBic5X8tRZbjkePxdSWks5rTKz7gaJpZM4Llie4>.