juliankrispel/react-text-selection-popover

Popover doesn't appear in Firefox.

marko-hologram opened this issue · 6 comments

Hello,

I tried your codesandbox example and it doesn't work in Firefox. Tested on Firefox 61.0.1 and Firefox Developer Edition 62.0b12 on Windows 10 (v1803).

It works in Chrome Version 68.0.3440.75 and Microsoft Edge 17 on the same machine.

Only one error appears in console: "Warning: Failed prop type: Invalid prop children of type object supplied to _class, expected function."

Error appears in all browsers, but popover still works in those mentioned so I'm not sure if that error is really related to the problem somehow.

@marko-hologram thanks for this! On it

I just tested on 60 on osx and it seems to work

@marko-hologram I've tried this in firefox on windows and osx and it works.

Here's firefox for osx:

image

and here it is on windows:

image

I'll close this for now since I can't find a way to reproduce it. If you can please do let me know and we'll see to fixing it!

@juliankrispel I just tested it on my personal machine on windows 10 and it works, same version of Firefox. The first machine I tested was my work PC. Strange.

I guess it's just something totally unrelated to your code. Sorry for the false alarm.