juliankrispel/use-text-selection

unable to click on the popup

killerbytes opened this issue · 3 comments

killerbytes commented

clicking on the popup will immediately close the popup

juliankrispel commented

@killerbytes works for me, can you provide an example?

kbariotis commented

@juliankrispel I think you can reproduce on the example as well. Clicking on the pop-up will close it automatically. This is a problem for when say you add a button to the pop up and when clicking on it you don't have the popup to close. I have the same issue with the react-text-selection-popover module as well.

Thanks :)

juliankrispel commented

Ah I see what the misunderstanding here is, let me explain:
The Share me popover in the example is a div, therefore when clicking it the text selection is shifted to this element.
Making the element into a button or canceling the click event will keep the current text-selection intact. I've updated the example to use a button so it's less coonfusing.

Let me know if you have any questions, will close this issue for now.

  • 👍1