julien-duponchelle/python-mysql-replication

Fix missing charset setting in base.py

Closed this issue · 1 comments

Issue Description and Solution

The TestLatin1 test is currently failing and has therefore been excluded from the actual pytest run. Upon investigation, it appears that the charset setting (db["charset"] = charset) has been omitted in base.py.

def setUp(self, charset="utf8"):
# default
self.conn_control = None
db = copy.copy(self.database)
db["db"] = None
self.connect_conn_control(db)
self.execute("DROP DATABASE IF EXISTS pymysqlreplication_test")
self.execute("CREATE DATABASE pymysqlreplication_test")
db = copy.copy(self.database)
self.connect_conn_control(db)
self.stream = None
self.resetBinLog()
self.isMySQL56AndMore()
self.__is_mariaDB = None

I plan to add the missing charset setting and re-include the test_query_event_latin1 test in the pytest suite.

Special thanks to @sean-k1 for the assistance😄

Closed by PR #565