julien-duponchelle/python-mysql-replication

[readme] mysql-server-settings part has a deprecated variable

gongyisheng opened this issue · 3 comments

gongyisheng commented

Hi, I'm setting up binlog subscription using this package and I notice that the mysql-server-settings part contains a deprecated variable.

mysql version: >8.0

Quote from mysql doc:

expire_logs_days is deprecated, and you should expect it to be removed in a future release. Instead, use binlog_expire_logs_seconds, which sets the binary log expiration period in seconds.

sean-k1 commented

@gongyisheng
Hello Thanks for reporting

Cool
I think it would be good to fix the readme with binlog_expire_log_seconds, which has been replaced since Mysql 8.0.

Would you be willing to work on this issue?

gongyisheng commented

Hi @sean-k1, sure, I can help submit a PR to fix it.

  • 👍2
sean-k1 commented

@gongyisheng I assgined you thnaks!

  • 👍1