jumbojett/c9.ide.theme.jett

remove mutation observer for chat

nightwing opened this issue · 1 comments

I'll change chat plugin to add "you" or "own-message" class by default.

The other thing is anim-start class added in https://github.com/jumbojett/c9.ide.theme.jett/blob/master/plugin.js#L185
Why is it required? looks like using delay in animation would accomplish the same.

@nightwing Apologies for the delay. I just noticed this issue.

I'll change chat plugin to add "you" or "own-message" class by default.
The mutation observer was added due to the lack of CSS classes on those elements

If they were present by default then "yes" the mutation observer could be removed! Can you reference a commit to the collab plugin so I can verify this?

Why is it required? looks like using delay in animation would accomplish the same.

You're correct again. This was coded on the fly. CSS3 delay could accomplish the same.

Feel free to submit a PR. :)