NiM inappropriately intercepts `cmd+i`

Question

NiM inappropriately intercepts `cmd+i`

Closed this issue 7 years ago · 7 comments

Environment

OS X 10.12.6 (16G29)
Chrome 60.0.3112.90 (Official Build) (64-bit)
NiM 0.13.8

What happened?

After installing NiM, I was working in Google Docs and attempted to use cmd+i to italicize some text but nothing happened. Disabling NiM, cmd+i worked again. Inspecting manifest.json, I noticed that cmd+i was registered as the open devtools keyboard shortcut when it should be cmd+option+i (View -> Developer -> Developer Tools ⌥⌘I).

What did you expect to happen?

I did not expect NiM to intercept keyboard shortcuts.

Thank you for NiM, for the reasons you outline in your blog post it's a real time saver. 🍻

Answer 1 · 2017-10-06T15:30:25.000Z

That is actually expected functionality. If you would like to change the shortcut or disable it, you can do that from Chrome (bottom of extensions page "Keyboard shortcuts").

cmd+option+i is the shortcut for devtools and has nothing to do with NiM.

Sorry for the late response on this. Been super busy!

Answer 2 · 2017-10-06T17:13:49.000Z

Hi @june07, thanks for the reply.

I don't think I explained the problem clearly. If you look at the line of code I linked, NiM registers cmd+i (the OS X keyboard shortcut for italics in WYSIWYG editors like Gmail or Google Docs) as "open devtools". I feel that when the NiM extension is enabled, I should be able to have normal use of a common keyboard shortcut such as cmd+i in an unrelated tab such as Gmail. As it is now, cmd+i is rendered non-functional in all of Chrome when NiM is enabled.

I think a more obscure keyboard shortcut such as cmd+option+shift+i would be more appropriate and would not conflict with pages that have keybindings for cmd+i.

Thanks again for NiM, total lifesaver.

Don't work too hard 🍻

Answer 3 · 2017-10-09T16:56:11.000Z

Clay, Totally understand where you are coming from. In which case you can change the setting to whatever you like (ie "cmd+option+shift+i"), see screenshot. I get what you are saying about common keyboard shortcuts, however you're the first person to mention this. I personally never use the italics shortcut (or italics very much for that matter). And for a developer who doesn't use the shortcut, I felt it was better to use a common, but least used shortcut. Hey, thanks for the great feedback and thanks. It's very much appreciated and keeps me going. <https://mailtrack.io/> Sent with Mailtrack <https://chrome.google.com/webstore/detail/mailtrack-for-gmail-inbox/ndnaehgpjlnokgebbaldlmgkapkpjkkb?utm_source=gmail&utm_medium=signature&utm_campaign=signaturevirality>

…

On Fri, Oct 6, 2017 at 10:13 AM, Clay Walker ***@***.***> wrote: Hi @june07 <https://github.com/june07>, thanks for the reply. I don't think I explained the problem clearly. If you look at the line of code I linked, NiM registers cmd+i (the OS X keyboard shortcut for italics in WYSIWYG editors like Gmail or Google Docs) as "open devtools". I feel that when the NiM extension is enabled, I should be able to have normal use of a common keyboard shortcut such as cmd+i in an unrelated tab such as Gmail. As it is now, cmd+i is rendered non-functional in all of Chrome when NiM is enabled. I think a more obscure keyboard shortcut such as cmd+option+shift+i would be more appropriate and would not conflict with pages that have keybindings for cmd+i. Thanks again for NiM, total lifesaver. Don't work too hard 🍻 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#21 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AK099pyBhYOpc1UjiACOGxohujl1soNQks5spl_OgaJpZM4O7Vu7> .

Answer 4 · 2017-10-10T20:16:16.000Z

Took me forever to figure out what extension was blocking the cmd+i shortcut in every rich text editor I use on any website... this is a bad decision.

Answer 5 · 2017-10-17T05:01:59.000Z

A solution which should satisfy all. #31 Would love some feedback, particularly from @ianstormtaylor . Thanks.

Change will be pushed shortly to the Chrome web store.

Answer 6 · 2017-10-17T05:31:29.000Z

Pushed. http://june07.com/nim

Answer 7 · 2017-10-17T17:02:06.000Z

@june07 I just reinstalled and tried it out, I think #31 is a fine compromise of principles. I think this will help people who are caught off guard. Then they can figure out how to change/disable the shortcut.

Thanks again!