tam315/react-compare-image

A few suggestions

Closed this issue · 3 comments

mrkenng commented

Nice script you have here! thank you! Was playing around today and all is good however can I suggest that you can add label for before and after text? Also, the ability to add for the handle, color, overlay and etc?

maybe like ;

tam315 commented

@mrkenng
Thanks for using my library. (and don't forget star my repo 😉 )

It seems a good idea to add labels.

I think that

  • Users should be able to:
    • specify the label contents
    • choose whether or not to display labels
  • Labels need to be as simple as possible.

Unfortunately I'm busy recently, So PR is always welcome.

OscarCR88 commented

I think that's a quite open feature request, because the position, and stiliyng of the label. It'd be interesting to see how you guys solve that.

tam315 commented

@mrkenng
Today, I released beta version of this library including label functions.
As this beta version uses Hooks, it works only with react & react-dom > v16.8 though.

yarn add react-compare-image@beta

sample(in the middle of the page):
https://v1--hungry-wiles-4117ce.netlify.com/