Reduce E2E snapshot flakiness
dlqqq opened this issue · 1 comments
dlqqq commented
Description
The E2E test job is currently failing on main: https://github.com/jupyter-server/jupyter-scheduler/actions/runs/5670886374
Looking at the test report, there are two failures:
- "shows notebook toolbar button" -- fails because the debugger is sometimes on, sometimes off. This test should use a more narrow locator that captures exclusively the left half of the notebook toolbar, rather than the entire main area widget.
- "shows newly created job in list view" -- the content of the table is shifted to the right by a few pixels. I'm not sure what's happening here; it could be an upstream CSS change the affects the visual layout. I think just updating the snapshot and making sure the test isn't flaky is sufficient.
dlqqq commented
BTW, reminder that please update playwright snapshots will automatically update the snapshots. Alternatively, you can use the workflow_dispatch UI under the "Actions" tab to run the workflow directly. I recommend the latter, as it shows you the progress and state of the workflow, while the former fails silently when an error is raised.