jupyter/services

All buffers ignored when serializing to binary

Closed this issue · 1 comments

Looking at the code, I think that this line means that if we are serializing to binary, any key of buffers is ignored, no matter where it is in the message. Rather, what we want is to just ignore the top-level buffers key. We'll have to do that manually (i.e., remove that one key, then stringify the entire message without this replacer).

(I haven't tested this - just noticed it when browsing the code.)