Maybe still issues with test_large_io_doesnt_hang on windows?
bollwyvl opened this issue · 3 comments
bollwyvl commented
Seeing some test fails on conda-forge/terminado-feedstock#38, looking into it:
if future_cell[0].cancelled() or not future_cell[0].done():
> raise TimeoutError("Operation timed out after %s seconds" % timeout)
E asyncio.exceptions.TimeoutError: Operation timed out after 30.0 seconds
..\_test_env\lib\site-packages\tornado\ioloop.py:528: TimeoutError
------------------------------ Captured log call ------------------------------
WARNING tornado.general:autoreload.py:128 tornado.autoreload started more than once in the same process
Maybe i missed some test dep changes? Might be the weekend before i can investigate further...
bollwyvl commented
Yep, was missing pytest-timeout
: now it's just win/pypy38 and win/cpython39, so might be flake:
KoopaKing commented
Ah, yeah, I may have tuned that timeout too tightly... on my system that test was taking around 20 seconds, but I didn't want it to take forever on failures.
blink1073 commented
Builds are passing on conda-forge now, I think we're good!