jupytercad/JupyterCAD

Cannot download JCAD file from file browser in JupyterCAD (it works with other file types)

SylvainCorlay opened this issue · 5 comments

SylvainCorlay commented

Testing from JupyterLite, this results in the following error in the JS console.

Uncaught (in promise) Error: Content whose type is "jcad" cannot be downloaded
    at u (index.js:127:23)
    at async index.js:170:34
martinRenou commented

It seems the (hidden) exception is "Error: Content whose type is "jcad" cannot be downloaded" coming from here https://github.com/jupyterlite/jupyterlite/blob/main/packages/application-extension/src/index.tsx#L209

I will see to fix it

  • 🚀1
martinRenou commented

jupyterlite/jupyterlite#1521 Should fix it

  • 👍1
  • 🚀1
SylvainCorlay commented

Should we redeploy with JupyterLite v0.4.4 and close this issue @martinRenou ?

  • 👍2
martinRenou commented

Latest deployment uses jupyterlite-core 0.4.4 and I can confirm this is fixed and I can now download .jcad files after edits!