Automatically update package.json version from setup.py
manics opened this issue · 6 comments
Proposed change
An additional version string was added in #1689:
Can we link this up to setup.py so that the version is automatically updated to match the BinderHub version?
Alternative options
Do nothing
Who would use this feature?
It would ensure all the npm package version matches the BinderHub version
Would this mean we need to publish a version to PyPI each time we publish to npm?
If we want automated releases (#1666) then yes.... unless we can have some logic to conditionally publish one package but not the other?
IMO the breaking changes in these two packages might differ, so I think it's probably ok to version these separately?
We have adopted use pf tbump quite systematically with success and positive feedback, instead of writing code in setup.py, i suggest we hardcode it and let tbump update it in all locations we have the string.
For practical reasons I prefer to see only have one version to track for all parts in this repo, even if it could make sense to let a js client drift.
Given there seems to be consensus on this, I'm happy to go with it especially as other people are doing the work :D :D
I think we should keep versioneer (or some other automated versioning tool) because we're installing dev versions of BinderHub in production.