Remove `setup_rsession`
ryanlovett opened this issue · 1 comments
Proposed change
This extension has two setup functions, setup_rserver
and setup_rsession
, although only setup_rserver
is actually used. Those functions map to RStudio's rserver
and rsession
executables. rserver
is the main executable of RStudio Server and manages user sessions and authentication, while rsession
is the executable for individual R sessions. Originally this extension launched rsession
because the multi-user capabilities were not needed, however at some point we pivoted to rserver
since that seemed to be more reliable for us. I kept the setup_rsession
code around in case we ever decided we wanted or needed to go back.
However, keeping the unused function around means that some things (like _get_timeout
) are duplicated.
Alternative options
Alternatively, we can move the duplicate parts (_get_timeout
) into a larger scope.
Who would use this feature?
Contributors won't have to know where there's an unused function.
(Optional): Suggest a solution
We could also revisit setup_rsession
and see if it is still viable, or perhaps the better choice? Perhaps it avoids the whole auth redirect issue that pops up under some circumstances.