`fetchVersion` only works if the extension was built
Closed this issue · 3 comments
Description
This is rather a request for confirmation than a bug report.
In _version.py
, fetchVersion
searches package.json
in the current folder (that is the folder of the python sources):
This means the version resolution works only if the extension was built (i.e. there is a labextension
folder containing the package.json
in the current folder).
Is this the desired behaviour ? Would it not be more robust to search directly for package.json
in the extension folder (i.e. the parent folder of the python sources) ?
Thank you for opening your first issue in this project! Engagement like this is essential for open source projects! 🤗
If you haven't done so already, check out Jupyter's Code of Conduct. Also, please try to follow the issue template as it helps other other community members to contribute more effectively.
You can meet the other Jovyans by joining our Discourse forum. There is also an intro thread there where you can stop by and say Hi! 👋
Welcome to the Jupyter community! 🎉
This means the version resolution works only if the extension was built
Yes indeed.
Is this the desired behaviour ? Would it not be more robust to search directly for
package.json
in the extension folder (i.e. the parent folder of the python sources) ?
Unfortunately, we can not look outside of the python package as that code may not be in the source folder.
Unfortunately, we can not look outside of the python package as that code may not be in the source folder.
Ah indeed, I understand now. Thanks for the clarification !