Images don't display
Closed this issue · 8 comments
See #162 (comment).
Description
In RTC images won't display.
Reproduce
- Install JupyterLab and jupyter-collaboration.
- Open an image from the file browser.
- See image not shown.
Expected behavior
Images should be displayed.
Jpterm is able to show images using a YBlob.
Context
- Operating System and version: Linux Ubuntu 22.04
- JupyterLab version: 4.0.9
- jupyter-collaboration version: 2.0.0
With
jupyter-collaborationinstalled, even if I'm not in an active collab session, the image gets uploaded with RTC.
What do you mean "the image gets uploaded"?
Apologies for the confusion. Should have said - "With jupyter-collaboration installed, even if I'm not in an active collab session, and if i upload an image to jupyterlabs, the image gets uploaded with RTC."
did that clarify?
So your issue is not that double-clicking on an image in the file browser doesn't show the image? I don't really get what it means that the image gets uploaded with RTC.
Let me clarify.
My issue, like yours, is that images don't display after I upload them and try to view them from the file browser.
I was also commenting that even when I'm not in an active collaboration session, and I upload an image, the image is marked as being uploaded with RTC. See screenshot. Perhaps this is expected behavior. I'm not familiar enough with the framework to know.
Oh I see now, thanks!
Yes the RTC: prefix in the path identifies the drive, but this is not the issue here.
The problem is that the frontend asks for a document of type file, which corresponds to a YUnicode shared document, but this doesn't handle binary data. Instead, it should ask for a blob which correspond to a YBlob.
Ack! Appreciate the clarification!
This is still an issue with JupyterLab 4.1.8 and Jupyter Collaboration 2.1.2. Images are still not displaying with RTC enabled.
It should be fixed in jupyter-collaboration v2.1.3.