New branch: `suggestions`
Closed this issue · 12 comments
I would like to create a new branch, maybe called suggestions, where we would implement new features for the suggestion system. The first PR against this new branch could be:
This is to be able to work freely while not blocking any release of jupyter-collaboration, and to iron out the details as we figure them out. Please let me know if there are objections.
Now that jupyter-collaboration v3.0.0 is out, maybe we should instead create a 3.0.0 branch and commit the suggestion system work in main?
Not sure, maybe it's more convenient if main is used for releasing 3.0.x and future 3.1.x for now, since it's not clear how fast the suggestions system will stabilize? (avoid too many backports).
Yes, maybe the suggestion system should target v4 then, and we should create a 4.0.0 branch?
In that case, maybe it's fine to keep the suggestions branch for now, and we create the 4.0.0 branch when needed and when we have more visibility?
Yes, the only thing is if @trungleduc needs pre-releases to ease his work in JupyterCAD. I was thinking that we could pre-release v4.
Right, having a way to make pre-releases would be useful.
But do we already know if the work on suggestions will require a major release? Or will it be additive without breaking changes, so it could be made available in a 3.x minor release?
with the eventual update related to the Websocket handler, I'm fine working with the PRs.
Hi all, the suggestions branch is not created yet?
Hmm didn't you said that you were fine working with PRs?
Hmm didn't you said that you were fine working with PRs?
yes, but it's is the case of jupytercad. However, I want to open a PR adding JS APIs to your endpoint. Should I open it against your branch in your fork?
No you're right, I'll create the suggestions branch and merge #382.
Great! Thanks