jupyterlab/jupyter-renderers

production build not happening automatically when releasing python packages

jasongrout opened this issue · 1 comments

When I released the last versions of the packages, I had to do clean out the js builds before starting the python release process, otherwise I was ending up with some builds that were not production builds (i.e., were not minimized, etc.). I thought that I wouldn't have to do a git clean -dfx before doing the python build. This would be good to look into, as right now if you don't clean, it seems you release packages that are about 2x as big because the js is not minified.

jtpio commented

Maybe first invoking the clean:all script:

"clean:all": "jlpm run clean:lib && jlpm run clean:labextension && jlpm run clean:dist",

Here:

"build-py": "rimraf dist && mkdir -p dist && lerna exec --concurrency 4 -- python setup.py sdist bdist_wheel && lerna exec --concurrency 4 -- mv dist/* ../../dist/",

Might be enough?