jupyterlab/jupyterlab-hdf5

Modernize signature of `get` method in backend

telamonian opened this issue · 1 comments

telamonian commented

I keep forgetting about this, but

jupyterlab-hdf5/jupyterlab_hdf/baseHandler.py

Lines 108 to 109 in 8ea9fc0

@gen.coroutine
def get(self, path):

needs to become

    from tornado import web

    @web.authenticated
    async def get(self):

This will:

  • update the (deprecated) tornado coroutine to the native python async support
  • add https authentication to the endpoint, which is just a Good Idea

@loichuder If you're currently writing unittests for the enpoints, you'll probably want to make sure this change has been made before you get in too deep (it may subtlely change some behavior). You can just add this change to unittest PR, or I can take care of it if you prefer

loichuder commented

I am not that deep into the tests yet so you can make any changes you see fit and I will change my tests accordingly

  • 👍1