The `phpmyadmin::vhost` class is outdated

[Aethylred]

The puppetlabs/puppetlabs-apache module has been updated and your vhost class is no longer working.

I've had to patch the Apache module further to make everything work, it's here: https://github.com/nesi/puppetlabs-apache/tree/all_features

And the incantation looks like this:

  class {'apache':  }
  class {'apache::mod::php': }
  class { 'phpmyadmin': }
  phpmyadmin::server{ 'default': }
  @@phpmyadmin::servernode { "${::ipaddress}":
      server_group => 'default',
  }

  # Not using the vhost set up by phpmyadmin module
  # it's not compatible with our later & patched version of the apache module
  apache::vhost{'mysql_test_phpmyadmin':
    servername  => $::fqdn,
    port        => 80,
    ssl         => false,
    docroot     => "${phpmyadmin::params::doc_path}/",
    aliases     => [
      { alias => 'phpmyadmin', path => $phpmyadmin::params::doc_path },
      { alias => 'PhpMyAdmin', path => $phpmyadmin::params::doc_path }
    ],
    directories => [
      {
        path => "${phpmyadmin::params::doc_path}/setup/",
      },
      {
        path  => "${phpmyadmin::params::doc_path}/libraries/",
        order => "deny,allow",
        deny  => "from All",
        allow => "from None",
      },
      {
        path => "${phpmyadmin::params::doc_path}/setup/lib/",
        order => "deny,allow",
        deny  => "from All",
        allow => "from None",
      },
      {
        path => "${phpmyadmin::params::doc_path}/setup/frames/",
        order => "deny,allow",
        deny  => "from All",
        allow => "from None",
      }
    ],
  }

[justicel]

Okay, thanks for the info. I'll take a look at the newest release of the apache module and update accordingly!

[justicel]

I'm not entirely certain which piece of the new apache module you're having issues with. I pulled down the latest version of the git master branch from puppetlabs and started a fresh server instance. I was able to run through and compile the manifest with no issue and as well the phpmyadmin interface appears to work.

Can you add further details about exactly which changes you believe were made to the apache module which stop this from working?

[justicel]

Whoops. Messed up environment variable so the test system was using the old module version. Looking into (should be fixing) shortly.

[justicel]

Ugghh... This is an unbelievably daft change on the part of the module maintainers. I imagine this is going to break compatibility with hundreds of other modules out there. I think I can get away with using the custom_fragment definition.

[justicel]

Thanks for notifying me about this change. I have updated both github and the puppet forge with a new version of the module.

[abraham1901]

@justicel, thanks for the code! It's works for me.