justinmanley/Leaflet.Illustrate

Textbox mouseover/out handlers enabling/disabling dragging causes dragging to be enabled when you don't want it to be

benglass opened this issue · 0 comments

The textbox html element added by this plugin includes event handlers on mouseover/out that enable/disable dragging on the map.

This is problematic because dragging my be disabled for some other reason. For example Leaflet Draw disables dragging when you start drawing shapes. If you then mouseover and mouseout of a textbox then you re-enable dragging.

I have monkey patched the _enableTyping method in our install to remove those dragging lines and everything works fine, so I'm not sure why they are necessary. If they are not required I can submit a PR to remove them.

https://github.com/justinmanley/Leaflet.Illustrate/blob/master/src/core/L.Illustrate.Textbox.js#L160