justinmayer/virtualfish

auto_activation: 2.5.3 breaks auto-deactivation

akurtz-penguin opened this issue · 3 comments

akurtz-penguin commented

  • I am using Fish shell version 3.1 or higher.

  • I am using Python version 3.6 or higher.

  • I have searched the issues (including closed ones) and believe that this is not a duplicate.

  • If related to a plugin, I prefixed the issue title with the name of the plugin.

  • OS version and name: Ubuntu 20.04

  • Fish shell version: 3.3.1

  • VirtualFish version: 2.5.3

Issue

When using virtualfish 2.5.3 and the auto_activation plugin, cd out of the .venv enabled directory does not disable the virtualenv. cd to another .venv directory does change to the new virtualenv. 2.5.2 works as expected. I am not using the project plugin.

justinmayer commented

Can you try the code in existing PR #210 and let me know if that resolves the issue you observed?

justinmayer commented

Hi Aaron. Could you test the recently-released 2.5.4 version and see whether that addresses the problem you observed?

akurtz-penguin commented

2.5.4 fixes the issue, thank you.