justinsalamon/scaper

Output audio format should match input format

justinsalamon opened this issue · 2 comments

From @epicycles and @haerdogan:

Scaper used to make outputs in the same format (e.g., float32 vs int16) as the audio input, but since #55 was merged it is always outputting int16, regardless of the input.

@haerdogan traced this down to the code that fixes sox off-by-one errors, and wrote a pull request to handle this (the currently closed without merge #86).

@pseeth will create a PR for this based on @haerdogan's proposed solution in #86.

Yeah, feel free to copy something from my fork if it helps. I have not tested it well enough and it may cause some issues.

Fixed via #88