jvoisin/fortify-headers

The test runner is broken

Opened this issue · 4 comments

q66 commented

I just noticed that the test runner does not actually fail on any failures.

Fixed in f3c0bfd

q66 commented

that's not a fix, it's the make command that should exit with 1 if anything fails

I don't think there is an easy elegant way to make the makefile exit with 1 should a test fail, while making it run all the tests.

q66 commented

sure there is, you're already running a shell snippet, just make it a little bigger and if any of the tests returns non-zero, set a variable and if the variable is set at the end, error

or make it a separate helper script and invoke that