jwasham/coding-interview-university

Translation: Vietnamese

letientai299 opened this issue · 16 comments

letientai299 commented

This is the dicussion thread for Vietnamese translation.
I'm working on it. Will make a PR when done.

Check it out here.

thovo commented

Can you show me how to contribute in this project?

  • 👍1
letientai299 commented

Until now, because I work alone, I just go from top to bottom.

Now, I think we should pick the section we want to work, and notice each other that we are working on it. Here's my proposal:

Workflow

  • Fork my repo
  • Raise an issue on my project
    • Just name the section you want to work on. We won't touch the section other had picked.
    • The section should be listed on Table of content. So that we won't get
      conflict about formatting when picking sub sections.
    • One section as a time.
  • Append/insert the works in order.
  • Update the Table of content to, make sure the anchor link works on Github.
  • When we complete our section, make a PR into my repo, refer to and close the related issue.
  • Pick another section...
  • We could also review each other works and propose update.

Formatting

  • Don't hardwrap, because this doc contains lost of link, hardwrap only make it unreadable.
  • Use space, not tab.
  • Remove any trailing whitespace.
  • Try to make sure our works look like the original.

How do you think?

  • 👍3
  • ❤️1
thovo commented

Look good to me! BTW, which sections you are working on?

letientai299 commented

Nothing. I have commited all recent works. Will raise an issue when I pick new section.

dangkhoasdc commented

@letientai299 : did you missed me?

I also want to translate the repo to Vietnamese. Can you please email me to talk about the translation?

jarvisluong commented

Hi!
I just updated some content in the Vietnamese version. Can you take a look at it and comment?

Link to PR: #173

  • 👍2
thovo commented

@letientai299 : Could you please recap what we have done so far? I will continue to next missing part this weekend.

letientai299 commented

I think it's better to leave this open for discussion related to Vietnamese translation. Other issues related to original work of course belong to their own issues.

oanhnn commented

I think we should rename README-vn.md to README-vi.md
Because, Vietnamese has code is vi
https://en.wikipedia.org/wiki/Vietnamese_language

  • 👍4
letientai299 commented

PR are welcome 😄.

thovo commented

Any PR is welcome, that's true but I don't think change the code name is that much important, as we need to add new translations, we are currently stopping for months without new update.

tiendn commented

Hi 👍
I just discovered an issue at line 265
[Xem tài liệu về các ngôn ngữ ở đây] (programming-language-resources.md)
Update
[Xem tài liệu về các ngôn ngữ ở đây] (../programming-language-resources.md)

  • 👍2
thovo commented

@tiendn thank to point out, could you please make some change!

tiendn commented

@thovo , Done PR ! 👍

neihousaigaai commented

I've just fixed some typo of file README-vi and I've created a PR here:

#356

ducdongmg commented

The Vietnamese version has not been updated for a long time, so there is a lot of redundant information still available and the documents have not been updated according to the latest link.

Just updated it at #1411